lighttpd
/
lighttpd1.4
2
0
Fork 0
Code Issues Releases Wiki Activity

[core] disable keep-alive if HTTP/1.1 CL and TE 

disable keep-alive and close connection after servicing request
if HTTP/1.1 Content-Length and Transfer-Encoding: chunked are
received in the same HTTP/1.1 request.

x-ref:
  RFC9112 HTTP/1.1
  https://httpwg.org/specs/rfc9112.html#rfc.section.6.1.p.15
  "A server MAY reject a request that contains both Content-Length
   and Transfer-Encoding or process such a request in accordance
   with the Transfer-Encoding alone. Regardless, the server MUST
   close the connection after responding to such a request to
   avoid the potential attacks."
This commit is contained in:
Glenn Strauss 2023-08-02 13:19:46 -04:00
parent 0558138ce9
commit a30858452e
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/request.c
View File

@ -477,6 +477,13 @@ static int http_request_parse_single_header(request_st * const restrict r, const
break;
case HTTP_HEADER_TRANSFER_ENCODING:
if (HTTP_VERSION_1_1 != r->http_version) {
/* RFC9112 HTTP/1.1 Section 6.1. Transfer-Encoding
* https://httpwg.org/specs/rfc9112.html#rfc.section.6.1.p.16
* A server or client that receives an HTTP/1.0 message containing a
* Transfer-Encoding header field MUST treat the message as if the
* framing is faulty, even if a Content-Length is present, and close
* the connection after processing the message. */
r->keep_alive = 0;
return http_request_header_line_invalid(r, 400,
HTTP_VERSION_1_0 == r->http_version
? "HTTP/1.0 with Transfer-Encoding (bad HTTP/1.0 proxy?) -> 400"
@ -1249,6 +1256,14 @@ http_request_parse (request_st * const restrict r, const int scheme_port)
/* (-1 == r->reqbody_length when Transfer-Encoding: chunked)*/
if (-1 == r->reqbody_length
&& light_btst(r->rqst_htags, HTTP_HEADER_CONTENT_LENGTH)) {
/* RFC9112 HTTP/1.1 Section 6.1. Transfer-Encoding
* https://httpwg.org/specs/rfc9112.html#rfc.section.6.1.p.15
* A server MAY reject a request that contains both Content-Length
* and Transfer-Encoding or process such a request in accordance
* with the Transfer-Encoding alone. Regardless, the server MUST
* close the connection after responding to such a request to
* avoid the potential attacks. */
r->keep_alive = 0;
/* RFC7230 Hypertext Transfer Protocol (HTTP/1.1): Message Syntax and Routing
* 3.3.3. Message Body Length
* [...]