diff --git a/NEWS b/NEWS index a9916b7e..038cb49e 100644 --- a/NEWS +++ b/NEWS @@ -10,6 +10,7 @@ NEWS * [mod_dirlisting] fix memory leak if pcre fails * [mod_fastcgi,mod_scgi] fix resource leaks on spawning backends * [mod_magnet] fix memory leak + * add comments for switch fall throughs - 1.4.34 * [mod_auth] explicitly link ssl for SHA1 (fixes #2517) diff --git a/src/connections.c b/src/connections.c index 8a2774dc..130bcbbc 100644 --- a/src/connections.c +++ b/src/connections.c @@ -1477,6 +1477,7 @@ int connection_state_machine(server *srv, connection *con) { break; case HANDLER_COMEBACK: done = -1; + /* fallthrough */ case HANDLER_WAIT_FOR_EVENT: /* come back here */ connection_set_state(srv, con, CON_STATE_HANDLE_REQUEST); diff --git a/src/mod_fastcgi.c b/src/mod_fastcgi.c index e925b262..0e155531 100644 --- a/src/mod_fastcgi.c +++ b/src/mod_fastcgi.c @@ -3018,7 +3018,7 @@ static handler_t fcgi_write_request(server *srv, handler_ctx *hctx) { break; } - + /* fallthrough */ case FCGI_STATE_PREPARE_WRITE: /* ok, we have the connection */ diff --git a/src/request.c b/src/request.c index 6bdaf578..5ee072dc 100644 --- a/src/request.c +++ b/src/request.c @@ -1023,6 +1023,7 @@ int http_request_parse(server *srv, connection *con) { case '\t': /* strip leading WS */ if (value == cur) value = cur+1; + /* fallthrough */ default: if (*cur >= 0 && *cur < 32 && *cur != '\t') { if (srv->srvconf.log_request_header_on_error) {